roachtest: loqrecovery wipe killed nodes #102119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously loq recovery tests kept data of killed nodes. This is confusing dead node detector as it finds unexpected dead nodes and fails tests. This commit adds node wiping so that detector doesn't trean nodes to be part of the cluster. Epic: none Release note: None
aliher1911
requested review from
srosenberg and
smg260
and removed request for
a team
|
This change is |
|
FYI: we capture recovery outcome in perf regardless of end cluster state. Wiping should take care of dead node detector. Perf artifacts are unaffected by wipe and they should still be captured after successful run. |
|
I think this was resolved over in #102162, we can drop this. |
|
Ah good, they added another opt-out. When I looked originally it wasn't there yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously loq recovery tests kept data of killed nodes. This is confusing dead node detector as it finds unexpected dead nodes and fails tests.
This commit adds node wiping so that detector doesn't trean nodes to be part of the cluster.
Release note: None
Fixes #102078