Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sem/tree: remove TODO #101944

Merged
merged 1 commit into from
Apr 20, 2023
Merged

sem/tree: remove TODO #101944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions pkg/sql/sem/tree/function_definition.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,6 @@ func (fd *ResolvedFunctionDefinition) MatchOverload(
) (QualifiedOverload, error) {
matched := func(ol QualifiedOverload, schema string) bool {
if ol.IsUDF {
// TODO(mgartner/chengxiong-ruan): Differentiate between functions
// defined with `Body` and UDFs, now that we use `Body` for built-in functions.
return schema == ol.Schema && (paramTypes == nil || ol.params().MatchIdentical(paramTypes))
}
return schema == ol.Schema && (paramTypes == nil || ol.params().Match(paramTypes))
Expand Down