build: add missing plpgsql build rules

[e-mbrown]

Resolve: #101544

The "Github CI"/ "Lint" target in TC was failing due to missing plpgsql build rules. This commit should add the rules.

Release note: None

[cockroach-teamcity]

This change is 

[knz]

The main issue I'm seeing here is that the new plpgsql depends on the sql/parser package; and so the source code for the latter needs to be ready before the source code for the former is processed. I'll show what I mean in a separate commit.

[knz]

Ok we're out of the woods - i seems the package dependency doesn't matter for file generation.

[e-mbrown]

Hm, we are getting this error still undefined: lexbase, previously the error was undefined: lexbase.DOT_DOT or other keyword. Ricky thinks that goimports might not be getting called, or maybe it is returning an incorrect result for some reason.

Reviewable status: complete! 0 of 0 LGTMs obtained

[knz]

drat, it failed again. I'm looking further now

[knz]

This is the failure:

[21:30:53] :			 [run] # github.com/cockroachdb/cockroach/pkg/sql/plpgsql/parser
[21:30:53] :			 [run] plpgsql-gen.y:260: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:261: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:262: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:263: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:264: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:265: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:266: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:268: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:269: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:270: undefined: lexbase
[21:30:53] :			 [run] plpgsql-gen.y:270: too many errors

I think i know what's up. i'll try something.

[knz]

Here's how to repro locally:

rm pkg/sql/plpgsql/parser/lexbase/tokens.go
rm pkg/sql/plpgsql/parser/lexbase/keywords.go
rm pkg/sql/plpgsql/parser/plpgsql.go
make pkg/sql/plpgsql/parser/plpgsql.go

The issue is because the code needs to import lexbase, but goimports doesn't know how to add it unless the lexbase files have been generated already.

there are 2 fixes possible:

• add a dependency to only generate plpgsql.go after the other files have been generated already; OR
• add the import manually to plpgsql.y

I think the latter is easier. I'll try this next.

[knz]

Next hurdle below . @rickystewart why did the Bazel CI target not find this already? Is this linter not running in bazel? It's a super important linter.

    lint_test.go:95:
        pkg/sql/plpgsql/parser/plpgsql-gen.y:692: Parse(): message argument is not a constant expression
        Tip: use YourFuncf("descriptive prefix %s", ...) or list new formatting wrappers in pkg/testutils/lint/passes/fmtsafe/functions.go.
        N.B. additional entry is required functions in the main package. See functions.go#requireConstFmt

[rickystewart]

Generally we don't have lints on for generated code.

[knz]

@ZhouXing19 you might be interested in the diff for the latest commit I added to this PR.

--- a/pkg/sql/plpgsql/parser/plpgsql.y
+++ b/pkg/sql/plpgsql/parser/plpgsql.y
@@ -688,7 +689,8 @@ getdiag_item: unreserved_keyword {
     case "returned_sqlstate":
       $$.val = plpgsqltree.PlpgsqlGetdiagReturnedSqlstate;
     default:
-      setErr(plpgsqllex, errors.New("unrecognized GET DIAGNOSTICS item " + $1 ))
+      // TODO(jane): Should this use an unimplemented error instead?
+      setErr(plpgsqllex, errors.Newf("unrecognized GET DIAGNOSTICS item: %s", redact.Safe($1)))
   }
 }

[knz]

Generally we don't have lints on for generated code.

@rickystewart This is a problem: the "generated code" for all files is generated from templates that do not have the .go extension, but are written by humans. If these templates contain code that violates our lint rules and bazel doesn't detect that, it's bad.

[knz]

This is a problem: the "generated code" for all files is generated from templates that do not have the .go extension, but are written by humans. If these templates contain code that violates our lint rules and bazel doesn't detect that, it's bad.

Filed this separate issue for that: #102191.

[rickystewart]

This is a problem: the "generated code" for all files is generated from templates that do not have the .go extension, but are written by humans. If these templates contain code that violates our lint rules and bazel doesn't detect that, it's bad.

If we can find a list of which "generated code" files should and should not be linted, then it'll be easy to apply it. I suspect that we have not fully thought through which "generated code" files are and are not lint-worthy.

[knz]

Let's move the lint discussion to #102191.

[knz]

I'm cautiously optimistic that my latest amend has fixed the remaining CI issues.

I'll disconnect from the computer now. If CI is indeed happy in the end feel free to squash and merge.

[knz]

LGTM modulo squashing the commits together.

NB: you'll need to git fetch (or pull) my last commit locally from your remote branch before you can squash.

[knz]

i'm going to go ahead and merge this so that the remainder of the team doesn't continue to worry something is amiss.

bors r+

[craig]

Build succeeded:

• Bazel Essential CI (Cockroach)

[e-mbrown]

blathers backport 23.1 22.2

[blathers-crl]

Encountered an error creating backports. Some common things that can go wrong:

1. The backport branch might have already existed.
2. There was a merge conflict.
3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

---

error creating merge commit from b7ba298 to blathers/backport-release-23.1-101930: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 23.1 failed. See errors above.

---

error creating merge commit from b7ba298 to blathers/backport-release-22.2-101930: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2 failed. See errors above.

---

_{🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.}