Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: cap the tenant IDs that can be allocated via create_tenant #101928

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Apr 20, 2023

Requested by @yuzefovich here.

This patch introduces a limit (MaxUint32) to the fixed IDs that can be
selected by crdb_internal.create_tenant. This ensures that there are
always IDs remaining available for CREATE TENANT after the maximum
value has been selected via create_tenant.

Release note: None
Epic: CRDB-23559

knz added 2 commits April 20, 2023 19:40
This patch introduces a limit (MaxUint32) to the fixed IDs that can be
selected by `crdb_internal.create_tenant`. This ensures that there are
always IDs remaining available for CREATE TENANT after the maximum
value has been selected via `create_tenant`.

Release note: None
@knz knz requested a review from yuzefovich April 20, 2023 17:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :lgtm:

Reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @knz)

@knz
Copy link
Contributor Author

knz commented Apr 20, 2023

bors r=yuzefovich

@craig
Copy link
Contributor

craig bot commented Apr 20, 2023

Build succeeded:

@craig craig bot merged commit fe19f93 into cockroachdb:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants