release-23.1: server: support multi-span statistics endpoint #101877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Extends: #96223 This PR extends the implementation of our SpanStats RPC endpoint to fetch stats for multiple spans at once. By extending the endpoint, we amortize the cost of the RPC's node fanout across all requested spans, whereas previously, we were issuing a fanout per span requested. Additionally, this change batches KV layer requests for ranges fully contained by the span, instead of issuing a request per fully contained range. Release note (sql change): span statistics are unavailable on mixed-version clusters
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
blathers-backport
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-101378
branch
from
cff1a58 to
b0a7afc
Compare
blathers-crl
bot
requested review from
srosenberg and
smg260
and removed request for
a team
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-101378
branch
from
ece2060 to
84dbb3e
Compare
blathers-crl
bot
requested review from
dhartunian,
j82w,
renatolabs,
THardy98 and
zachlite
|
This change is |
maryliag
approved these changes
Apr 26, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @j82w, @THardy98, and @zachlite)
|
TYFR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #101378 on behalf of @THardy98.
/cc @cockroachdb/release
Epic: None
Extends: #96223
This PR extends the implementation of our SpanStats RPC endpoint to fetch stats for multiple spans at once. By extending the endpoint, we amortize the cost of the RPC's node fanout across all requested spans, whereas previously, we were issuing a fanout per span requested. Additionally, this change batches KV layer requests for ranges fully contained by the span, instead of issuing a request per fully contained range.
Note that we do not deprecate the
start_keyandend_keyfields as they're used to determine whether an old node is calling out to a node using the new proto format.The changes here explicitly do not support mixed-version clusters.
BENCHMARK RESULTS
Here are some benchmark results from running:
Note that
HEADis actually a temp change to revert to old logic (request per span) andHEAD^is the new logic (multi-span request). As such the increases in latency/memory are actually reductions.Some notable improvements particularly with requests for spans with fewer ranges. After a point, the raw number of ranges becomes the bottleneck, despite reducing the number of fanouts. Not sure if there is a better way to fetch range statistics but I think the improvement here is enough for this PR. If improvements for fetching range statistics are identified, they can be done in a follow up PR and backported.
Release note (sql change): span statistics are unavailable on mixed-version clusters
Release justification: performance improvement fetching span statistics in bulk