Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: add crdb_internal.pretty_value #101825

Merged
merged 1 commit into from
May 9, 2023

Conversation

stevendanna
Copy link
Collaborator

This composes nicely with crdb_internal.scan to allow inspection of table data and other command line tools like cockroach debug pebble.

Epic: none

Release note: None

@stevendanna stevendanna requested review from Xiang-Gu and a team April 19, 2023 11:51
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@stevendanna stevendanna requested a review from msbutler April 19, 2023 11:51
This composes nicely with crdb_internal.scan to allow inspection of
table data and other command line tools like cockroach debug pebble.

Epic: none

Release note: None

Co-authored-by: Xiang Gu <[email protected]>
@stevendanna stevendanna force-pushed the crdb-internal-pretty-value branch from 958dea9 to b4bfe1a Compare May 9, 2023 09:59
Copy link
Contributor

@Xiang-Gu Xiang-Gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks for realizing this utility! Now, with scan, pretty_key, and pretty_value, we can inspect kv pairs of a table/index in a human-readable format!

@stevendanna
Copy link
Collaborator Author

bors r=Xiang-Gu,msbutler

@craig
Copy link
Contributor

craig bot commented May 9, 2023

This PR was included in a batch that was canceled, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented May 9, 2023

Build succeeded:

@craig craig bot merged commit f614c52 into cockroachdb:master May 9, 2023
@msbutler
Copy link
Collaborator

@stevendanna is it worth backporting this to 23.1 and 22.2 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants