kv: all leases start as expiration based #101765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
andrewbaptist
force-pushed
the
2023-04-18-only-transfer-expiration-lease
branch
from
8e9d89f to
2eb4d19
Compare
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
The metrics are a little confusing since they are measured as a delta since the last time the call is made in some cases, but in other cases they seem to be cumulative. Need to figure this out more still....
andrewbaptist
force-pushed
the
2023-04-18-only-transfer-expiration-lease
branch
4 times, most recently
from
cdd7850 to
477efa5
Compare
Starting a lease as an epoch lease is risky. The problem is the lease may be marked as transferred to the new node, but the node can take time to realize it is the leaseholder. THis was partially addressed as part of cockroachdb#85629, however there were still cases where this can occur. Specifically in the cases of non-cooperative lease acquisition. While we don't have an example of this causing a problem because the range is likely idle at this point, it is certainly possible to make a contrived case where this happens. Epic: none Release note: None
andrewbaptist
force-pushed
the
2023-04-18-only-transfer-expiration-lease
branch
from
477efa5 to
7a4fb36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a lease as an epoch lease is risky. The problem is the lease may be marked as transferred to the new node, but the node can take time to realize it is the leaseholder. THis was partially addressed as part of #85629, however there were still cases where this can occur. Specifically in the cases of non-cooperative lease acquisition. While we don't have an example of this causing a problem because the range is likely idle at this point, it is certainly possible to make a contrived case where this happens.
Epic: none
Release note: None