Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamingccl: don't require TLS certificates #101729

Merged
merged 1 commit into from
May 9, 2023
Merged

streamingccl: don't require TLS certificates #101729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions pkg/ccl/streamingccl/streamingest/stream_ingestion_planning.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,16 +166,6 @@ func ingestionPlanHook(
if err != nil {
return err
}
q := streamURL.Query()

// Operator should specify a postgres scheme address with cert authentication.
if hasPostgresAuthentication := (q.Get("sslmode") == "verify-full") &&
q.Has("sslrootcert") && q.Has("sslkey") && q.Has("sslcert"); (streamURL.Scheme == "postgres") &&
!hasPostgresAuthentication {
return errors.Errorf(
"stream replication address should have cert authentication if in postgres scheme: %s", streamAddress)
}

streamAddress = streamingccl.StreamAddress(streamURL.String())

// TODO(adityamaru): Add privileges checks. Probably the same as RESTORE.
Expand Down