Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: liveness: clarify IncrementEpoch race error and log as INFO #101617

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 16, 2023

Backport 1/1 commits from #93787 on behalf of @erikgrinaker.

/cc @cockroachdb/release


Resolves #93791.

Epic: none
Release note: None


Release justification:

@blathers-crl blathers-crl bot requested a review from a team as a code owner April 16, 2023 19:36
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-93787 branch from c2975c7 to edb2381 Compare April 16, 2023 19:36
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 16, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-93787 branch from 67e882c to bcac1ca Compare April 16, 2023 19:36
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 16, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from erikgrinaker and tbg April 16, 2023 19:36
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 16, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-22.2-93787 branch from bcac1ca to c24edff Compare April 17, 2023 15:57
@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-22.2-93787 branch from c24edff to 143697b Compare May 8, 2023 11:03
@erikgrinaker
Copy link
Contributor

CI is hitting #102834.

@erikgrinaker erikgrinaker force-pushed the blathers/backport-release-22.2-93787 branch from 143697b to df95e71 Compare May 27, 2023 17:40
@github-actions
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

@erikgrinaker erikgrinaker merged commit 15505fa into release-22.2 Jun 19, 2023
@erikgrinaker erikgrinaker deleted the blathers/backport-release-22.2-93787 branch June 19, 2023 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants