ui: add KeyedCachedDataReducer selector factory util, refactor jobs page props to use RequestState #101481
Conversation
|
This change is |
xinhaoz
force-pushed
the
jobs-page-props-update
branch
3 times, most recently
from
2e21858 to
f3c5305
Compare
xinhaoz
changed the title
This commit adds the `createSelectorForKeyedCachedDataField` utility to help create selector functions that will transform the data of type `KeyedCachedDataReducer` into `RequestState<T>` expected by components in cluster-ui. Epic: none Release note: None
xinhaoz
force-pushed
the
jobs-page-props-update
branch
from
f3c5305 to
a7dd422
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)
pkg/ui/workspaces/cluster-ui/src/store/jobs/jobs.reducer.ts line 14 at r2 (raw file):
import { JobsRequest, JobsResponse } from "src/api/jobsApi"; import { DOMAIN_NAME } from "../utils"; import moment from "moment-timezone";
I think it needs to be imported from moment-timezone, related to the work of adding timezone to console pages
Refactor the jobs page components to use `RequestState` to read the jobs response parts. Epic: none Release note: None
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/store/jobs/jobs.reducer.ts line 14 at r2 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
I think it needs to be imported from moment-timezone, related to the work of adding timezone to console pages
Done.
xinhaoz
force-pushed
the
jobs-page-props-update
branch
from
a7dd422 to
d6d6615
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
|
TFTR! |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
See individual commits.
Release note: None
Epic: CRDB-25476