kvcoord: introduce RangeUnavailableError and DistSender fail-fast behavior #101455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
iAaronBuck
force-pushed
the
aaronbuck_introduceRangeUnavailableError
branch
from
b2141eb to
3d0996f
Compare
iAaronBuck
changed the title
iAaronBuck
force-pushed
the
aaronbuck_introduceRangeUnavailableError
branch
from
3d0996f to
690e9cd
Compare
iAaronBuck
force-pushed
the
aaronbuck_introduceRangeUnavailableError
branch
6 times, most recently
from
fc5efa3 to
525f620
Compare
iAaronBuck
force-pushed
the
aaronbuck_introduceRangeUnavailableError
branch
2 times, most recently
from
fa40af4 to
aaef511
Compare
…avior Previously, the RangeUnavailableError did not exist, and the DistSender would continue infinitely if no responses from replicas representing a range were received, as noted in the fail-fast DistSender work requested in cockroachdb#74503. This fail-fast work also requires a RangeUnavailableError. Therefore, this PR resolves that unmet requirement by introducing the error along with creating the fail-fast behavior within DistSender. Epic: none Release note (performance improvement): introduces the RangeUnavailableError and enables fail-fast behavior in DistSender.
iAaronBuck
force-pushed
the
aaronbuck_introduceRangeUnavailableError
branch
from
aaef511 to
8e6ba60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the RangeUnavailableError did not exist,
and the DistSender would continue infinitely if
no responses from replicas representing a range
were received, as noted in the fail-fast DistSender
work requested in #74503. This fail-fast work also
requires a RangeUnavailableError. Therefore, this PR
resolves that unmet requirement by introducing the error
along with creating the fail-fast behavior within DistSender.
Epic: none
Release note (performance improvement): introduces the
RangeUnavailableError and enables fail-fast behavior in
DistSender.