Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: update predecessor version and test fixtures for 23.2 version-upgrade roachtest #101252

Merged

Conversation

cameronnunez
Copy link
Contributor

@cameronnunez cameronnunez commented Apr 11, 2023

Part of https://cockroachlabs.atlassian.net/browse/REL-284

This PR generates test fixtures for acceptance/version-upgrade so that this test can run on 23.2. It also updates the predecessor version for 23.2

Release note: None

@cameronnunez cameronnunez requested a review from celiala April 11, 2023 20:14
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cameronnunez cameronnunez changed the title roachtest: update predecessor version and test fixtures for 23.2 version-upgrade roachtest [WIP] roachtest: update predecessor version and test fixtures for 23.2 version-upgrade roachtest Apr 11, 2023
@cameronnunez cameronnunez force-pushed the update-predecessor-version-23.2 branch 3 times, most recently from 68cae08 to e931a41 Compare April 28, 2023 18:09
…ion-upgrade roachtest

This PR generates test fixtures for `acceptance/version-upgrade`
so that this test can run on 23.2. It also updates the predecessor
version for 23.2

Release note: None
@cameronnunez cameronnunez force-pushed the update-predecessor-version-23.2 branch from e931a41 to c8faf9e Compare April 28, 2023 20:41
@cameronnunez cameronnunez changed the title [WIP] roachtest: update predecessor version and test fixtures for 23.2 version-upgrade roachtest roachtest: update predecessor version and test fixtures for 23.2 version-upgrade roachtest Apr 28, 2023
@cameronnunez cameronnunez marked this pull request as ready for review April 28, 2023 20:43
@cameronnunez cameronnunez requested a review from a team as a code owner April 28, 2023 20:43
@cameronnunez cameronnunez requested review from herkolategan, smg260 and renatolabs and removed request for a team April 28, 2023 20:43
Copy link
Contributor

@renatolabs renatolabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @celiala, @herkolategan, and @smg260)

Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woo! 🎉

Thank you for all the effort to unblock this @cameronnunez and @renatolabs 💯 ❤️ !

@cameronnunez
Copy link
Contributor Author

thanks for the help all!

@cameronnunez
Copy link
Contributor Author

bors r=celiala,renatolabs

@craig
Copy link
Contributor

craig bot commented Apr 28, 2023

Build succeeded:

@craig craig bot merged commit 47396a0 into cockroachdb:master Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants