gc: add explicit cases for clear range in randomized tests #101245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
All failures are unrelated tests to the test that this pr adds. 😞 |
erikgrinaker
approved these changes
Apr 12, 2023
pkg/kv/kvserver/gc/gc_random_test.go
Outdated
| now hlc.Timestamp | ||
| ttlSec int32 | ||
| intentAgeSec int32 | ||
| clearRangeKeys int64 // Set to 0 for test default value or -1 to disable. |
There was a problem hiding this comment.
nit: probably not worth a CI roundtrip, but using the same name clearRangeMinKeys as the actual parameter would be clearer.
Previously there was very small chance that clear range requirements are met in randomized gc testing. This commit adds explicit test cases where clear range thresholds set specifically low to ensure test sees different ways of splitting requests into batches. Epic: none Release note: None
aliher1911
force-pushed
the
add_randomized_gc_variants
branch
from
9076b46 to
45c3540
Compare
erikgrinaker
added
the
backport-23.1.x
|
bors r=erikgrinaker |
1 similar comment
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was very small chance that clear range requirements are met in randomized gc testing. This commit adds explicit test cases where clear range thresholds set specifically low to ensure test sees different ways of splitting requests into batches.
Release note: None
Touches #98156