Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: introduce foundations to support configurable timezone display #101151

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 10, 2023

Backport 1/1 commits from #99848 on behalf of @zachlite.

/cc @cockroachdb/release


This commit adds the foundational dependencies and components needed to display timestamps in DB console in a user's preferred timezone.

Introduced:

  • A dependency on moment-timezone in DB console and Cluster UI.
  • A cluster setting: ui.display_timezone.
  • A timezone context with a default value of "UTC". This enables backwards-compatability for cluster-ui components. No changes in cloud are needed, and cluster-ui components will continue to display timestamps in UTC.
  • A context provider at the top of DB console's component tree.

Part of: #40419
Epic: https://cockroachlabs.atlassian.net/browse/CRDB-24406
Release note: None


Release justification: to unblock delivery of successful GA

This commit adds the foundational dependencies and components needed
to display timestamps in DB console in a user's preferred timezone.

Introduced:
- A dependency on `moment-timezone` in DB console and Cluster UI.
- A cluster setting: `ui.display_timezone`.
- A timezone context with a default value of "UTC". This
  enables backwards-compatability for cluster-ui components.
  No changes in cloud are needed, and cluster-ui components will continue
  to display timestamps in UTC.
- A context provider at the top of DB console's component tree.

Epic: https://cockroachlabs.atlassian.net/browse/CRDB-24406
Release note: None
@blathers-crl blathers-crl bot requested a review from a team April 10, 2023 19:24
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99848 branch 2 times, most recently from 2f65b12 to 0f4b193 Compare April 10, 2023 19:24
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 10, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 10, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @sjbarag, @xinhaoz, and @zachlite)

@zachlite zachlite merged commit 80831fb into release-23.1 Apr 10, 2023
@zachlite zachlite deleted the blathers/backport-release-23.1-99848 branch April 10, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants