changefeedccl: fix pubsub v2 unit tests on AWS #101130
Merged
+21
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pubsub V2 tests would fail with ``` failed to start feed for job 0: pq: opening client: google: could not find default credentials. See https://developers.google.com/accounts/docs/application-default-credentials for more information ``` only on release-23.1 test runs because every other test was running on google cloud machines, where you didn't need to even have `gcloud` installed for it to work. This happens only on the initial attempt to initialize a PubsubClient when the GRPCConn is not overriden. This PR fixes it by skipping initialization entirely so that we don't have to deal with errors like this or having ensure the old connection is cleaned up before setting the mock one. Release note: None <what was there before: Previously, ...> <why it needed to change: This was inadequate because ...> <what you did about it: To address this, this patch ...>
|
This change is |
miretskiy
approved these changes
Apr 10, 2023
|
bors r+ |
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #100968
Resolves #100969
Resolves #100970
Resolves #100971
Resolves #100972
Resolves #100973
Resolves #100974
Resolves #100985
Resolves #100986
Resolves #100987
Resolves #100988
Resolves #101014
Resolves #101015
Resolves #101016
Resolves #101017
Resolves #101018
Resolves #101019
Resolves #101020
Resolves #101030
Resolves #101031
Resolves #101032
Resolves #101033
Resolves #101034
Resolves #101035
Resolves #101036
Resolves #101040
Resolves #101041
Resolves #101042
Resolves #101043
Resolves #101044
Resolves #101045
Resolves #101062
Resolves #101063
Resolves #101064
Resolves #101065
Resolves #101066
Resolves #101067
Resolves #101079
Resolves #101080
Resolves #101081
Resolves #101082
Resolves #101083
Resolves #101084
Resolves #101085
Resolves #101086
Resolves #101099
Resolves #101100
Resolves #101106
Resolves #101107
Resolves #101113
Resolves #101114
Resolves #101115
The pubsub V2 tests would fail with
only on release-23.1 test runs because every other test was running on google cloud machines, where you didn't need to even have
gcloudinstalled for it to work. This happens only on the initial attempt to initialize a PubsubClient when the GRPCConn is not overriden.This PR fixes it by skipping initialization entirely so that we don't have to deal with errors like this or having ensure the old connection is cleaned up before setting the mock one.
Release note: None