-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: sql: link issue to unimplemented mutations in udfs #101127
release-23.1: sql: link issue to unimplemented mutations in udfs #101127
Conversation
9294cc8
to
2e2d48a
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR! Only test failure is a known issue that has been fixed since this backport was created.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rytaft)
2e2d48a
to
03915f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @rharding6373)
Backport 1/1 commits from #100965 on behalf of @rharding6373.
/cc @cockroachdb/release
Links an issue to the unimplemented errors for mutations in UDFs.
Epic: None
Informs: #87289
Fixes: #99715
Release note: None
Release justification: Modifies an existing error message, so change is not risky.