autoconfig: prevent a data race in TestAutoConfig #101076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
20230410-fix-race
branch
2 times, most recently
from
4e4f723 to
6c65840
Compare
The calls to Peek and Pop can run concurrently. Release note: None
adityamaru
approved these changes
Apr 10, 2023
|
TFYR! bors r=adityamaru |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
bors r- |
|
Canceled. |
Before this change, the test was kicking off tasks concurrently with version upgrades. To reduce noise in logs, this patch fixes it to make it wait until upgrades have completed. Release note: None
|
bors r=adityamaru |
|
bors r- |
|
Canceled. |
Release note: None
|
bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #101069.
The calls to Peek and Pop can run concurrently.
Release note: None
Epic: CRDB-23559