Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: bump tpccbench timeout #101058

Merged
merged 1 commit into from
Apr 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions pkg/cmd/roachtest/tests/tpcc.go
Original file line number Diff line number Diff line change
Expand Up @@ -979,8 +979,6 @@ type tpccBenchSpec struct {
// change (i.e. CockroachDB gets faster!).
EstimatedMax int

// MinVersion to pass to testRegistryImpl.Add.
MinVersion string
// Tags to pass to testRegistryImpl.Add.
Tags map[string]struct{}
// EncryptionEnabled determines if the benchmark uses encrypted stores (i.e.
Expand Down Expand Up @@ -1068,16 +1066,11 @@ func registerTPCCBenchSpec(r registry.Registry, b tpccBenchSpec) {
numNodes := b.Nodes + b.LoadConfig.numLoadNodes(b.Distribution)
nodes := r.MakeClusterSpec(numNodes, opts...)

minVersion := b.MinVersion
if minVersion == "" {
minVersion = "v19.1.0" // needed for import
}

r.Add(registry.TestSpec{
Name: name,
Owner: owner,
Cluster: nodes,
Timeout: 5 * time.Hour,
Timeout: 7 * time.Hour,
Tags: b.Tags,
EncryptionSupport: encryptionSupport,
Run: func(ctx context.Context, t test.Test, c cluster.Cluster) {
Expand Down