Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: roachtest: fix assertion in drain test #100959

Merged
merged 1 commit into from
Apr 7, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/cmd/roachtest/tests/drain.go
Original file line number Diff line number Diff line change
@@ -335,7 +335,7 @@ func runClusterNotAtQuorum(ctx context.Context, t test.Test, c cluster.Cluster)
"./cockroach node drain --self --insecure --drain-wait=10s",
)
t.L().Printf("drain output:\n%s\n%s\n", results.Stdout, results.Stderr)
require.Contains(t, results.Stderr, "could not check drain related cluster settings")
require.Regexp(t, "(cluster settings require a value of at least|could not check drain related cluster settings)", results.Stderr)
}

// prepareCluster is to start the server on nodes in the given cluster, and set