-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: kv: consider ErrReplicaNotFound and ErrReplicaCannotHoldLease to be retryable #100955
Merged
nvanbenschoten
merged 1 commit into
release-23.1
from
blathers/backport-release-23.1-98116
Jun 6, 2023
Merged
release-23.1: kv: consider ErrReplicaNotFound and ErrReplicaCannotHoldLease to be retryable #100955
nvanbenschoten
merged 1 commit into
release-23.1
from
blathers/backport-release-23.1-98116
Jun 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-98116
branch
from
April 7, 2023 20:27
7e8c7c6
to
59fb953
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
blathers-backport
This is a backport that Blathers created automatically.
O-robot
Originated from a bot.
labels
Apr 7, 2023
nvanbenschoten
force-pushed
the
blathers/backport-release-23.1-98116
branch
from
April 24, 2023 17:51
59fb953
to
ce101e8
Compare
Reminder: it has been 3 weeks please merge or close your backport! |
…etryable Fixes #96746. Fixes #100379. This commit considers ErrReplicaNotFound and ErrReplicaCannotHoldLease to be retryable replication change errors when thrown by lease transfer requests. In doing so, these errors will be retried by the retry loop in `Replica.executeAdminCommandWithDescriptor`. This avoids spurious errors when a split gets blocked behind a lateral replica move like we see in the following situation: 1. issue AdminSplit 2. range in joint config, first needs to leave (maybeLeaveAtomicChangeReplicas) 3. to leave, needs to transfer lease from voter_outgoing to voter_incoming 4(a). lease transfer request sent to replica that has not yet applied the replication change that added the voter_incoming to the range 4(b). lease transfer request delayed and delivered after voter_incoming has been transferred the lease, added to the range, then removed from the range. In either case, retrying the AdminSplit operation on these errors will ensure that it eventually succeeds. Release note (bug fix): Fixed a rare race that could allow large RESTOREs to fail with a `unable to find store` error.
nvanbenschoten
force-pushed
the
blathers/backport-release-23.1-98116
branch
from
June 1, 2023 15:22
ce101e8
to
e08ed28
Compare
tbg
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blathers-backport
This is a backport that Blathers created automatically.
no-backport-pr-activity
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #98116 on behalf of @nvanbenschoten.
Fixes #100984.
/cc @cockroachdb/release
Fixes #96746.
Fixes #100379.
This commit considers ErrReplicaNotFound and ErrReplicaCannotHoldLease to be retryable replication change errors when thrown by lease transfer requests. In doing so, these errors will be retried by the retry loop in
Replica.executeAdminCommandWithDescriptor
.This avoids spurious errors when a split gets blocked behind a lateral replica move like we see in the following situation:
replication change that added the voter_incoming to the range
4(b). lease transfer request delayed and delivered after voter_incoming has
been transferred the lease, added to the range, then removed from the
range.
In either case, retrying the AdminSplit operation on these errors will ensure that it eventually succeeds.
Release note (bug fix): Fixed a rare race that could allow large RESTOREs to fail with a
unable to find store
error.Release justification: avoids errors during splits, which can be seen during IMPORT and RESTORE.