storage: encode engine keys passed as checkpoint bounds #100940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
sumeerbhola
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @jbowens)
Previously, CreateCheckpoint would restrict a checkpoint by passing invalid keys to Pebble. This keys were unencoded `roachpb.Key`s without a version length last byte. The unit test is skipped, because it reveals another ununderstood problem. Close cockroachdb#100919. Informs cockroachdb#100935. Epic: none Release note: None
jbowens
force-pushed
the
checkpoint-enginekey
branch
from
1776c03 to
c61b6f5
Compare
|
TFTR! bors r=sumeerbhola |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CreateCheckpoint would restrict a checkpoint by passing invalid keys to Pebble. These keys were unencoded
roachpb.Keys without a version length last byte.The unit test is skipped, because it reveals another ununderstood problem.
Close #100919.
Informs #100935.
Epic: none
Release note: None