release-23.1: tree: apply functions to TEXT expressions compared with the @@ operator #100918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TSQuery and TSVector "matches" operator "@@" returns different results on CRDB vs. Postgres when one of the arguments is a TEXT expression. CRDB always applies a CAST, and only for constants. The rules at https://www.postgresql.org/docs/current/textsearch-intro.html#TEXTSEARCH-MATCHING specify: > The form text @@ tsquery is equivalent to to_tsvector(x) @@ y. > The form text @@ text is equivalent to to_tsvector(x) @@ plainto_tsquery(y). This PR adds these implicit function calls in these "matches" comparison expressions during type checking as well as a cast of TEXT to TSQuery when the other argument is a TSVector, which allows variable expressions to be handled. Fixes cockroachdb#98875 Fixes cockroachdb#98804 Release note (bug fix): This allows the text search @@ ("matches") operator to work with variable expressions and fixes incorrect results when one of the arguments is a TEXT expression and the other argument is a TEXT or TSQuery expression.
Release note: None
|
This change is |
|
release backport request here |
mgartner
changed the title
mgartner
approved these changes
Apr 7, 2023
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
@@operator type-checking" (sql: remove unnecessary casts in@@operator type-checking #100704)Please see individual PRs for details.
/cc @cockroachdb/release
Release justification: low risk backport for incorrect results with the @@ operator