Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: upgrades: use TestingBinaryMinSupportedVersion in tests #100874

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Apr 6, 2023

Backport 1/1 commits from #100726.

/cc @cockroachdb/release

Release justification: test only change


As described in #100552, it's important for this API to use TestingBinaryMinSupportedVersion in order to correctly bootstrap on the older version.

informs #100552
Release note: None

@rafiss rafiss requested a review from a team as a code owner April 6, 2023 20:49
@rafiss rafiss requested review from a team and renatolabs and removed request for a team April 6, 2023 20:49
@blathers-crl
Copy link

blathers-crl bot commented Apr 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss force-pushed the backport23.1-100726 branch 2 times, most recently from 3d2e84d to 54a0bd0 Compare April 7, 2023 00:59
As described in cockroachdb#100552, it's important for this API to use
TestingBinaryMinSupportedVersion in order to correctly bootstrap on the
older version.

Removed TestFixUserfileRelatedDescriptorCorruptionUpgrade and TestPreconditionBeforeStartingAnUpgrade
since they are for 22.2 migrations.

Release note: None
@rafiss rafiss force-pushed the backport23.1-100726 branch from 54a0bd0 to 68e6a87 Compare April 7, 2023 02:04
@rafiss rafiss merged commit 8f8aa8a into cockroachdb:release-23.1 Apr 7, 2023
@rafiss rafiss deleted the backport23.1-100726 branch April 7, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants