Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: cmd/roachtest: adjust disk-stalled roachtests TPS calculation #100849

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 6, 2023

Backport 1/1 commits from #100821 on behalf of @jbowens.

/cc @cockroachdb/release


Previously, the post-stall TPS calculation included the time that the node was stalled but before the stall triggered the node's exit. During this period, overall TPS drops until the gray failure is converted into a hard failure. This commit adjusts the post-stall TPS calculation to exclude the stalled time when TPS is expected to tank.

Epic: None
Informs: #97705.
Release note: None


Release justification: Non-production code changes.

Previously, the post-stall TPS calculation included the time that the node was
stalled but before the stall triggered the node's exit. During this period,
overall TPS drops until the gray failure is converted into a hard failure. This
commit adjusts the post-stall TPS calculation to exclude the stalled time when
TPS is expected to tank.

Epic: None
Informs: #97705.
Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner April 6, 2023 18:12
@blathers-crl blathers-crl bot requested review from srosenberg and smg260 and removed request for a team April 6, 2023 18:12
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100821 branch from 47d9abf to 0eabc54 Compare April 6, 2023 18:12
@blathers-crl blathers-crl bot requested review from herkolategan and itsbilal April 6, 2023 18:12
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from renatolabs April 6, 2023 18:12
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100821 branch from 8666311 to 0dc1f64 Compare April 6, 2023 18:12
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 6, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens merged commit 115b02c into release-23.1 Apr 11, 2023
@jbowens jbowens deleted the blathers/backport-release-23.1-100821 branch April 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants