Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: upgrades,backupccl: audit mixed version and upgrade tests #100832

Merged
merged 3 commits into from
Apr 7, 2023
Merged

release-23.1: upgrades,backupccl: audit mixed version and upgrade tests #100832

merged 3 commits into from
Apr 7, 2023

Conversation

adityamaru
Copy link
Contributor

@adityamaru adityamaru commented Apr 6, 2023 •
edited
Loading

Backport 2/4 commits from #100696.

/cc @cockroachdb/release

Please see individual commits.

Informs: #100552
Release justification: resolves part of a release blocker to audit our mixed version tests

@adityamaru
upgrades: rework job_info upgrade test
b1d7c1c 
This test has been rewritten to explicitly indicate
what version the test cluster is being bootstrapped
and upgraded to.

Informs: cockroachdb#100552
Release note: None
@adityamaru adityamaru requested review from dt and a team April 6, 2023 16:53
@adityamaru adityamaru requested a review from a team as a code owner April 6, 2023 16:53
@blathers-crl
Copy link

blathers-crl bot commented Apr 6, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru
backupccl: bump version on restore mixed version test
476f44a 
This change bumps the mixed version restore test
to use the current minimum binary version instead of
an older V22_2Start gate that will soon be deleted.

Informs: cockroachdb#100552
Release note: None
@adityamaru adityamaru force-pushed the backport23.1-100696 branch from f7ec7b9 to 476f44a Compare April 6, 2023 17:17
@adityamaru adityamaru merged commit 384a525 into cockroachdb:release-23.1 Apr 7, 2023
@adityamaru adityamaru deleted the backport23.1-100696 branch April 12, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dt dt dt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adityamaru @cockroach-teamcity @dt