Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvcoord, changefeedccl: Disable mux rangefeed #100713

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

miretskiy
Copy link
Contributor

@miretskiy miretskiy commented Apr 5, 2023

Disable mux rangefeed use in 23.1
This is a temporary fix to elliminate test flakes
on 23.1 release branch.

Fixes #99640
Fixes #100468
Fixes #99214
Fixes #99092

Release note: None
Release justification: 23.1 release test stability fix.

@miretskiy miretskiy requested a review from a team April 5, 2023 15:49
@miretskiy miretskiy requested a review from a team as a code owner April 5, 2023 15:49
@miretskiy miretskiy requested review from HonoreDB and removed request for a team April 5, 2023 15:49
@blathers-crl
Copy link

blathers-crl bot commented Apr 5, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@miretskiy miretskiy requested a review from pav-kv April 5, 2023 15:50
Disable mux rangefeed use in 23.1
This is a temporary fix to elliminate test flakes
on 23.1 release branch.

Release note: None
Release justification: 23.1 release test stability fix.
@irfansharif
Copy link
Contributor

Could we skip the "Fixes" moniker, for #99214 and #99092 at least? This is speculative, right? Since we don't understand whether/how mux rangefeed could cause the frontier timestamp to advance but drop the actual value updates?

@miretskiy
Copy link
Contributor Author

Could we skip the "Fixes" moniker, for #99214 and #99092 at least? This is speculative, right? Since we don't understand whether/how mux rangefeed could cause the frontier timestamp to advance but drop the actual value updates?

I think pr description describes this as a temporary test only fix on 23.1; it doesn't describe it as a mux rangefeed fix.
The speculation, backed up by lots of evidence, is that this problem occurs only when using mux rangefeed.
Thus this target fix is to enable us to release 23.1; while keeping metamorphic on master to arrive at the actual fix at some later time.

@miretskiy miretskiy merged commit c248656 into cockroachdb:release-23.1 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants