Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: skip TestLeaseRenewer #100693

Merged
merged 1 commit into from
Apr 5, 2023

Conversation

erikgrinaker
Copy link
Contributor

@erikgrinaker erikgrinaker commented Apr 5, 2023

This is flaky under race/deadlock, but also had a couple of failures that indicate minor races in (de)activating extensions. I won't have time to look into this immediately, so skipping it for now.

Touches #100689.

Epic: none
Release note: None

This is flaky under race/deadlock, but also had a couple of failures
that indicate minor races in (de)activating extensions. I won't have
time to look into this immediately, so skipping it for now.

Epic: none
Release note: None
@erikgrinaker erikgrinaker requested review from nvanbenschoten, andrewbaptist and a team April 5, 2023 13:19
@erikgrinaker erikgrinaker requested a review from a team as a code owner April 5, 2023 13:19
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Hopefully these can be figured out before 23.1 release.

@erikgrinaker
Copy link
Contributor Author

Yeah, it's a GA blocker since we need to get the Raft scheduler changes in.

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 5, 2023

Build succeeded:

@craig craig bot merged commit c14ba56 into cockroachdb:master Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants