roachtest/version-upgrade: re-enable schema changer workload #100651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
force-pushed
the
declarativeRandomFix
branch
2 times, most recently
from
f08b040 to
472d75f
Compare
fqazi
requested review from
srosenberg,
smg260 and
a team
and removed request for
a team
chengxiong-ruan
approved these changes
Apr 6, 2023
| @@ -326,6 +326,31 @@ var opDeclarative = []bool{ | |||
| validate: false, | |||
| } | |||
|
|
|||
| var opDeclarativeVersion = []clusterversion.Key{ | |||
| addColumn: clusterversion.V22_2, | |||
There was a problem hiding this comment.
Looks like we'd need to maintain this version list statement by statement, but I think that's probably fine.
There was a problem hiding this comment.
I was debating if we should use the check if supported function from the builder, but the problem is mixed version states here. The binary is built against a new version for the test, I'll add a comment with a rationale.
// This workload will maintain its own list of supported versions for declarative
// schema changer, since the cluster we are running against can be downlevel.
// The declarative schema changer builder does have a supported list but it's not
// sufficient for that reason.
Previously, the schema changer workload was disabled inside the version upgrade test because of intermittent job errors. This patch re-enables this workload again for the version upgrade test. It also updates the test to handle mixed version declarative schema changer support. Fixes: cockroachdb#100709 Release note: None
fqazi
force-pushed
the
declarativeRandomFix
branch
from
472d75f to
3b998ad
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the schema changer workload was disabled inside the version upgrade test because of intermittent job errors. This patch re-enables this workload again for the version upgrade test. It also updates the test to handle mixed version declarative schema changer support.
Fixes: #100409
Release note: None