Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrades: update helper fn ExecForCountInTxns to retry transactions #100641

Merged
merged 1 commit into from
Apr 5, 2023
Merged

upgrades: update helper fn ExecForCountInTxns to retry transactions #100641

merged 1 commit into from
Apr 5, 2023

Conversation

andyyang890
Copy link
Collaborator

@andyyang890 andyyang890 commented Apr 4, 2023 •
edited
Loading

This patch updates the ExecForCountInTxns helper function to retry
transactions to prevent spurious test failures.

Fixes: #100158

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 4, 2023
@andyyang890
upgrades: update helper fn ExecForCountInTxns to retry transactions
991e8e8 
This patch updates the ExecForCountInTxns helper function to retry
transactions to prevent spurious test failures.

Release note: None
@andyyang890 andyyang890 marked this pull request as ready for review April 5, 2023 13:43
@andyyang890 andyyang890 requested review from a team, rafiss and ajwerner April 5, 2023 13:43
rafiss
rafiss approved these changes Apr 5, 2023
View reviewed changes
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ajwerner)

@andyyang890
Copy link
Collaborator Author

TFTR!

bors r=rafiss

@craig craig bot merged commit 2428a0b into cockroachdb:master Apr 5, 2023
@craig
Copy link
Contributor

craig bot commented Apr 5, 2023

Build succeeded:

@blathers-crl blathers-crl bot mentioned this pull request Apr 5, 2023
Merged
@blathers-crl
Copy link

blathers-crl bot commented Apr 5, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error setting reviewers, but backport branch blathers/backport-release-23.1-100641 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100728/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@andyyang890 andyyang890 deleted the helper_txn_retry branch April 5, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@ajwerner ajwerner Awaiting requested review from ajwerner

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

upgrade/upgrades: TestRoleMembersIDMigration1500Users failed
3 participants
@andyyang890 @cockroach-teamcity @rafiss