Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: add hex payload/progress to system_jobs #100629

Merged
merged 1 commit into from
Apr 25, 2023
Merged

cli: add hex payload/progress to system_jobs #100629

merged 1 commit into from
Apr 25, 2023

Conversation

dt
Copy link
Member

@dt dt commented Apr 4, 2023

Release note: none.
Epic: none.

@dt dt requested a review from adityamaru April 4, 2023 19:14
@dt dt requested a review from a team as a code owner April 4, 2023 19:14
@blathers-crl
Copy link

blathers-crl bot commented Apr 4, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dt
Copy link
Member Author

dt commented Apr 5, 2023

Reworked taking inspiration from @abarganier's #100642.

@dt dt requested a review from abarganier April 5, 2023 01:30
@dt
cli: add hex payload/progress to system_jobs
c6487e2 
Release note: none.
Epic: none.
@dt dt requested a review from a team April 25, 2023 12:15
@dt dt added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 25, 2023
@dt dt requested review from adityamaru and removed request for adityamaru April 25, 2023 12:37
@dt
Copy link
Member Author

dt commented Apr 25, 2023

TFTRs!

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 25, 2023

Build succeeded:

@craig craig bot merged commit b89085a into cockroachdb:master Apr 25, 2023
@blathers-crl blathers-crl bot mentioned this pull request Apr 25, 2023
Merged
@dt dt deleted the sys-jobs branch April 25, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityamaru adityamaru adityamaru approved these changes

@knz knz knz approved these changes

@abarganier abarganier Awaiting requested review from abarganier

Assignees
No one assigned
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dt @cockroach-teamcity @knz @adityamaru