Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/server: move DataDistribution to systemAdminServer #100620

Merged
merged 1 commit into from
Apr 7, 2023
Merged

pkg/server: move DataDistribution to systemAdminServer #100620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pkg/server/admin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2973,7 +2973,14 @@ func (s *systemAdminServer) Decommission(
}

// DataDistribution returns a count of replicas on each node for each table.
func (s *adminServer) DataDistribution(
//
// TODO(kv): Now that we have coalesced ranges, this endpoint no longer reports
// accurate replica counts. Furthermore, since it doesn't take coalesced ranges
// into account, this endpoint doesn't work for secondary tenants whose ranges are
// *always* coalesced. Update this endpoint to handle coalesced ranges and
// implement tenant filtering, after which it can be moved back into the
// adminServer instead of the systemAdminServer.
func (s *systemAdminServer) DataDistribution(
ctx context.Context, req *serverpb.DataDistributionRequest,
) (_ *serverpb.DataDistributionResponse, retErr error) {
if err := s.requireViewClusterMetadataPermission(ctx); err != nil {
Expand Down