release-23.1: raftlog: correctly decode empty commands #100611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-100401
branch
from
641406f to
f43313a
Compare
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-100401
branch
from
9b59edd to
2930760
Compare
blathers-crl
bot
added
blathers-backport
|
This change is |
erikgrinaker
force-pushed
the
blathers/backport-release-23.1-100401
branch
from
2930760 to
3b96588
Compare
When unquiescing a Raft group, an empty command is proposed to wake the Raft leader. During application, empty entries are considered noops, but only if they don't have a command ID. However, Raft entry decoding would preserve the command ID of an empty payload. `CheckForcedErr()` thus no longer considered this a noop, instead returning an error because the `ProposerLeaseSequence` of 0 was older than the current lease. Construction and processing of this error had a non-negligible cost when unquiescing a large number of ranges. This patch makes sure such empty commands are decoded as empty entries, without a command ID, and thus considered noops. Epic: none Release note: None
erikgrinaker
force-pushed
the
blathers/backport-release-23.1-100401
branch
from
3b96588 to
7e2d441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #100401 on behalf of @erikgrinaker.
/cc @cockroachdb/release
When unquiescing a Raft group, an empty command is proposed to wake the Raft leader. During application, empty entries are considered noops, but only if they don't have a command ID. However, Raft entry decoding would preserve the command ID of an empty payload.
CheckForcedErr()thus no longer considered this a noop, instead returning an error because theProposerLeaseSequenceof 0 was older than the current lease. Construction and processing of this error had a non-negligible cost when unquiescing a large number of ranges.This patch makes sure such empty commands are decoded as empty entries, without a command ID, and thus considered noops.
Resolves #100400.
Epic: none
Release note: None
Release justification: fixes performance regression and errors due to incorrect decoding of Raft unquiescence commands.