upgrade/upgrades: fix TestUpgradeSchemaChangerElements race condition #100598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
force-pushed
the
TestUpgradeSchemaChangerElementsDeflake
branch
2 times, most recently
from
1a7d3ee to
bdbcb43
Compare
Previously, TestUpgradeSchemaChangerElements started a schema change and intentionally caused it to be paused. It then resumed this job and started a version upgrade. The version upgrade being tested is meant to pause schema change jobs intentionally, which could lead to the job getting paused again before it resumed. This patch, adds one more channel to ensure synchronization in this sequence. Additionally, we will further limit the scope of version to make this test a bit shorter, so that we are only focused on the upgrade for schema changes Fixes: cockroachdb#98602 Release note: None
fqazi
force-pushed
the
TestUpgradeSchemaChangerElementsDeflake
branch
from
bdbcb43 to
b8ffd10
Compare
chengxiong-ruan
approved these changes
Apr 6, 2023
|
@chengxiong-ruan TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Did you actually intend for this to close #98602 or a different issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, TestUpgradeSchemaChangerElements started a schema change
and intentionally caused it to be paused. It then resumed this job
and started a version upgrade. The version upgrade being tested is
meant to pause schema change jobs intentionally, which could lead
to the job getting paused again before it resumed. This patch, adds
one more channel to ensure synchronization in this sequence.
Additionally, we will further limit the scope of version to make
this test a bit shorter, so that we are only focused on the upgrade
for schema changes
Fixes: #98062.
Release note: None