Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlccl: deflake TestGCTenantJobWaitsForProtectedTimestamps #100511

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Apr 3, 2023

Fixes #94808

The tenant server must be shut down before the tenant record is removed; otherwise the tenant's SQL server will self-terminate by calling Stop() on its stopper, which in this case was shared with the parent cluster.

Release note: None

The tenant server must be shut down before the tenant record is
removed; otherwise the tenant's SQL server will self-terminate
by calling Stop() on its stopper, which in this case was shared with
the parent cluster.

Release note: None

Co-authored-by: Arul Ajmani <[email protected]>
Co-authored-by: adityamaru <[email protected]>
@knz knz requested review from arulajmani and adityamaru April 3, 2023 19:33
@knz knz requested a review from a team as a code owner April 3, 2023 19:33
@knz knz requested a review from DrewKimball April 3, 2023 19:33
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! :lgtm:

Should we add backport labels as well?

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @adityamaru and @DrewKimball)

@knz knz added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 3, 2023
@knz
Copy link
Contributor Author

knz commented Apr 3, 2023

bors r=adityamaru,arulajmani

@craig
Copy link
Contributor

craig bot commented Apr 3, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Apr 3, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error setting reviewers, but backport branch blathers/backport-release-23.1-100511 is ready: POST https://api.github.com/repos/cockroachdb/cockroach/pulls/100519/requested_reviewers: 422 Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the cockroachdb/cockroach repository. []

Backport to branch 23.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@knz knz deleted the 20230403-deflake-gc-test branch April 4, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pkg/ccl/testccl/sqlccl/sqlccl_test: TestGCTenantJobWaitsForProtectedTimestamps failed
4 participants