*: assorted test fixes (continued) #100483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
approved these changes
Apr 3, 2023
|
TFYR! bors r=stevendanna |
|
oops bors r- |
|
Canceled. |
knz
force-pushed
the
20230403-improve-import-failures
branch
from
a7301e5 to
a4fb87e
Compare
knz
changed the title
|
bors r=stevendanna |
knz
force-pushed
the
20230403-improve-import-failures
branch
from
a4fb87e to
74b16d2
Compare
|
Canceled. |
|
bors r=stevendanna |
|
bors r- |
|
Canceled. |
knz
changed the title
Release note: None
Prior to this change, the tests were calling `t.Fatal` on the wrong
`testing.T` reference, causing the details to be obscured like this:
```
testing.go:1343: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
```
This patch improves this and hopefully will reveal better causes for
test failures.
Release note: None
Release note: None
Release note: None
Release note: None
knz
force-pushed
the
20230403-improve-import-failures
branch
from
74b16d2 to
1351c88
Compare
|
bors r=stevendanna p=99 single on |
|
Build failed: |
Release note: None
This was referenced Apr 3, 2023
Release note: None
knz
requested review from
herkolategan and
smg260
and removed request for
a team
|
bors r=stevendanna p=99 single on |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #100477.
Includes #100490.
Rebased on top of #100487.
Epic: CRDB-28893