Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: upgrades: update system.web_sessions migration to handle orphaned rows #100244

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 31, 2023

Backport 1/1 commits from #100017 on behalf of @andyyang890.

/cc @cockroachdb/release


This patch updates the system.web_sessions user ID migration to delete
orphaned rows (i.e. rows corresponding to users that have been dropped)
after backfilling user IDs. They need to be deleted since they block
the addition of the NOT NULL constraint on the column.

Part of #87079

Release note: None


Release justification: Bug fixes and low-risk updates to new functionality

This patch updates the system.web_sessions user ID migration to delete
orphaned rows (i.e. rows corresponding to users that have been dropped)
after backfilling user IDs. They need to be deleted since they block
the addition of the NOT NULL constraint on the column.

Release note: None
@blathers-crl blathers-crl bot requested a review from a team March 31, 2023 00:09
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100017 branch from 108b484 to 51c394e Compare March 31, 2023 00:09
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 31, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100017 branch from d6ad2e6 to 715078b Compare March 31, 2023 00:09
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@andyyang890 andyyang890 requested a review from rafiss March 31, 2023 01:50
@andyyang890 andyyang890 merged commit 7e72aae into release-23.1 Mar 31, 2023
@andyyang890 andyyang890 deleted the blathers/backport-release-23.1-100017 branch March 31, 2023 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants