-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: rpc: Fix blackhole recv #100238
release-23.1: rpc: Fix blackhole recv #100238
Conversation
108b484
to
e0fbfa7
Compare
c524f2e
to
c402a7a
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Don't merge this without fixing #100275 |
Fixes: #99104 Informs #84289 As part of the previous fix for partition handling, we tracked the state of a previous attempt and use that result on the next attempt. However if there were multiple connections, we may only block system traffic connections and not default class connections. This change addresses that by ensuring a failed dialback attempt is remembered until we are able to successfully connect back to the pinging node. Epic: none Release note: None
c402a7a
to
9c97ee0
Compare
I updated it to include the changes from #100275 so it will be a single commit. I'm going to let this sit until Monday just to make sure nothing else comes out. |
Backport 1/1 commits from #99840 on behalf of @andrewbaptist.
/cc @cockroachdb/release
Fixes: #99104
Informs #84289
As part of the previous fix for partition handling, we tracked the state of a previous attempt and use that result on the next attempt. However if there were multiple connections, we may only block system traffic connections and not default class connections. This change addresses that by ensuring a failed dialback attempt is remembered until we are able to successfully connect back to the pinging node.
Epic: none
Release note: None
Release justification: This correctly fixes the asymmetric partition case and is required to complete that work.