Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: roachprod: set COCKROACH_CONNECT_TIMEOUT to 1200s during start #100197

Merged
merged 1 commit into from
Mar 31, 2023
Merged

release-23.1: roachprod: set COCKROACH_CONNECT_TIMEOUT to 1200s during start #100197

merged 1 commit into from
Mar 31, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 30, 2023 •
edited by msbutler
Loading

Backport 1/1 commits from #100182 on behalf of @msbutler.

/cc @cockroachdb/release

Previously the sql cmds invoked within roachprod start had an infinite timeout. This patch reduces the timeout to 10 minutes -- if a node can't start within 10 minutes because a roachprod client can't connect to the new crdb node, there's likely a problem.

We decided to make this change after a roachtest with a 10 hr time out hung for 10 hours due to an internal start cmd. See #99280.

Informs #99280

Release note: none

Release justification: test infra change

@msbutler
roachprod: set COCKROACH_CONNECT_TIMEOUT to 1200s during start
c40ae36 
Previously the sql cmds invoked within roachprod start had an infinite timeout.
This patch reduces the timeout to 10 minutes -- if a node can't start within 10
minutes because a roachprod client can't connect to the new crdb node, there's
likely a problem.

We decided to make this change after a roachtest with a 10 hr time out hung for
10 hours due to an internal start cmd. See #99280.

Informs #99280

Release note: none
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 30, 2023 19:21
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100182 branch from 244c452 to 0d7f673 Compare March 30, 2023 19:21
@blathers-crl blathers-crl bot requested review from smg260, renatolabs, jbowens and srosenberg and removed request for a team March 30, 2023 19:21
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-100182 branch from be0f5eb to c40ae36 Compare March 30, 2023 19:21
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 30, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 30, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

jbowens
jbowens approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@msbutler msbutler merged commit 37c2912 into release-23.1 Mar 31, 2023
@msbutler msbutler deleted the blathers/backport-release-23.1-100182 branch March 31, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbowens jbowens jbowens approved these changes

@smg260 smg260 Awaiting requested review from smg260 smg260 is a code owner automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs renatolabs is a code owner automatically assigned from cockroachdb/test-eng

@srosenberg srosenberg Awaiting requested review from srosenberg

Assignees

@msbutler msbutler

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @jbowens @msbutler