Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leaktest: ignore the opencensus worker #100099

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Mar 30, 2023

Fixes #100098.

Release note: None

@knz knz requested a review from stevendanna March 30, 2023 12:43
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz force-pushed the 20230330-goroutine-leak branch from be60b75 to b8b9f32 Compare March 30, 2023 12:48
Copy link
Collaborator

@herkolategan herkolategan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @stevendanna)

@knz
Copy link
Contributor Author

knz commented Mar 30, 2023

TFYRs
bors r=pavelkalinnikov,herkolategan

@knz
Copy link
Contributor Author

knz commented Mar 30, 2023

For @stevendanna 's entertainment, opencensus-go/stats/view/worker.go:

func init() {
        defaultWorker = NewMeter().(*worker)
        go defaultWorker.start()
        internal.DefaultRecorder = record
        internal.MeasurementRecorder = recordMeasurement
}

@craig
Copy link
Contributor

craig bot commented Mar 30, 2023

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Mar 30, 2023

Build succeeded:

@craig craig bot merged commit 476cd85 into cockroachdb:master Mar 30, 2023
@knz knz deleted the 20230330-goroutine-leak branch March 31, 2023 11:39
@knz
Copy link
Contributor Author

knz commented Mar 31, 2023

blathers backport 23.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgwire: flake in TestConnCloseCancelsAuth due to goroutine leak
4 participants