release-23.1: spanconfig: integrate SpanConfigBounds with the Store and KVSubscriber #100013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Previously, when constructing ValueBounds for any Int32 fields, we would check if the ConstraintBounds field was non-null, which wasn't intentional. This meant that we wouldn't clamp fields like GC TTL, number of voters, and number of replicas if ConstraintBounds wasn't set. Epic: none Release note: None
This patch allows us to declare keys/spans as datadriven input for datadriven tests in the spanconfig package. We'll make use of this in an upcoming commit. Epic: none Release note: None
This patch integrates `SpanConfigBounds` with the `KVSubscriber` and `spanconfig.Store`. The `spanconfig.Store` used by the `KVSubscriber` now has a handle to the global tenant capability state. It uses this to clamp any secondary tenant span configs that are not in conformance before returning them. By default, clamping of secondary tenant span configurations is turned off. It can be enabled using the `spanconfig.bounds.enabled` cluster setting. The setting is hidden. Fixes: #99689 Release note: None
The spanconfig package doesn't care about any capabilities other than span config bounds which are stored as Capabilities. This patch introduces a new `spanconfigbounds.Reader` interface which is intended to be a narrow, adapter interface over `tenantcapabilities.Reader`. We then use this new interface in the `KVSubscriber` and `Store`. Epic: none Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.1-99699
branch
2 times, most recently
from
082f1ab to
54e0952
Compare
blathers-crl
bot
added
blathers-backport
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
ajwerner
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @arulajmani)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 4/4 commits from #99699 on behalf of @arulajmani.
/cc @cockroachdb/release
This patch integrates
SpanConfigBoundswith theKVSubscriberandspanconfig.Store. Thespanconfig.Storeused by theKVSubscribernow has a handle to the global tenant capability state. It uses this to
clamp any secondary tenant span configs that are not in conformance
before returning them.
By default, clamping of secondary tenant span configurations is turned
off. It can be enabled using the
spanconfig.bounds.enabledclustersetting. The setting is hidden.
Fixes: #99689
Informs #99911
Release note: None
Release justification: GA blocker; only affects secondary tenants and is default off.