Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

persistedsqlstats: use background QoS level for work #99949

Closed
ajwerner opened this issue Mar 29, 2023 · 0 comments · Fixed by #107728
Closed

persistedsqlstats: use background QoS level for work #99949

ajwerner opened this issue Mar 29, 2023 · 0 comments · Fixed by #107728
Assignees
@xinhaoz
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced.

Comments

@ajwerner
Copy link
Contributor

ajwerner commented Mar 29, 2023 •
edited by cockroach-jira-scripts
Loading

Is your feature request related to a problem? Please describe.
The stats compaction job runs relatively expensive work using an internal executor. We can tell admission control to de-prioritize it, and we should.

Describe the solution you'd like
The code is

cockroach/pkg/sql/sqlstats/persistedsqlstats/compaction_exec.go

Lines 215 to 221 in 1a7e82f

it, err := c.ie.QueryIteratorEx(ctx,
"delete-old-sql-stats",
nil, /* txn */
sessiondata.InternalExecutorOverride{User: username.NodeUserName()},
delStmt,
qargs...,
)

We can pass QualityOfService in the InternalExecutorOverride.

This is a very easy win.

Jira issue: CRDB-26151
@ajwerner ajwerner added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced. labels Mar 29, 2023
@xinhaoz xinhaoz self-assigned this Jul 27, 2023
@xinhaoz xinhaoz mentioned this issue Jul 27, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 28, 2023
@annrpom @knz
@tbg @wenyihu6 @xinhaoz @adityamaru
Merge #107391 #107659 #107697 #107721 #107728 #107750 #107753
c0aabf1 
107391: roachtest: include link to testeng grafana in issue posts r=smg260,tbg a=annrpom

This adds a link, populated with relevant cluster name and test timeframe, to the testeng grafana instance for failed roachtests.

Fixes: #105894
Release note: None

107659: serverutils: provide SQLConn/SQLConnE in ApplicationLayerInterface r=stevendanna a=knz

Fixes  #107672.
Part of solving #107058.
Informs #106772.

Epic: CRDB-18499



107697: rpc: avoid crash in newPeer r=erikgrinaker a=tbg

It was previously possible to make a new peer while the old one was in the
middle of being deleted, which caused a crash due to to acquiring child metrics
when they still existed.

Luckily, this is easy enough to fix: just remove some premature optimization
where I had tried to be too clever.

Fixes #105335.

Epic: CRDB-21710
Release note: None (bug never released)

107721: asim: skip TestAllocatorSimulatorDeterministic and example_fulldisk r=wenyihu6 a=wenyihu6

We found some non-deterministic behavior in the allocator simulator (see #105904
for more details). For now, we are skipping these potentially flaky tests.

Release Note: None 
Epic: None

107728: persistedsqlstats: specify background qos for compaction job r=xinhaoz a=xinhaoz

The compaction job can be an expensive operation so we should de-prioritize it with the `UserLow` qos setting.

Fixes: #99949

Release note: None

107750: ui: fix app = empty string filter on stmts page r=xinhaoz a=xinhaoz

The filter on app name = empty string was not working on
the stmts page. This was due to the fact that we use (unset)
as the option in the filter to represent selecting the empty
string app name. However when filtering statements, the empty
string app name on the stmt was not changed accordingly.
this commit fixes this and also adds testing for the unset case.

Epic: none
Fixes: #107748

Release note (bug fix): Filter on stmts page works for
app name = empty string (represented as 'unset').

https://www.loom.com/share/2fee4f0fb7b04208803e0dac1d9694ab?sid=5cabecf9-1c2a-406b-89a8-b378ed07d329



107753: backupccl: deflake TestBackupAndRestoreJobDescription r=stevendanna a=adityamaru

This change sorts the jobs based on when they
were created to ensure we get a stable sort of
job descriptions.

Fixes: #107684
Release note: None

Co-authored-by: Annie Pompa <[email protected]>
Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Tobias Grieger <[email protected]>
Co-authored-by: wenyihu6 <[email protected]>
Co-authored-by: Xin Hao Zhang <[email protected]>
Co-authored-by: adityamaru <[email protected]>
@craig craig bot closed this as completed in 21163ac Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xinhaoz xinhaoz

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-quick-win Likely to be a quick win for someone experienced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

persistedsqlstats: specify background qos for compaction job xinhaoz/cockroach
2 participants
@ajwerner @xinhaoz