Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/util/future/future_test: TestFuture failed #99804

Closed
cockroach-teamcity opened this issue Mar 28, 2023 · 3 comments · Fixed by #106187
Closed

pkg/util/future/future_test: TestFuture failed #99804

cockroach-teamcity opened this issue Mar 28, 2023 · 3 comments · Fixed by #106187
Assignees
@miretskiy
Labels
A-cdc Change Data Capture branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-cdc
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 28, 2023 •
edited by exalate-issue-sync bot
Loading

pkg/util/future/future_test.TestFuture failed with artifacts on release-23.1 @ 3551dc089ac3efcb3772df2109164dcb01e79d8f:

=== RUN   TestFuture
    future_test.go:74: 
        	Error Trace:	pkg/util/future/future_test_test/pkg/util/future/future_test.go:74
        	Error:      	Received unexpected error:
        	            	channel not ready
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | pkg/util/future/future_test_test.TestFuture.func4
        	            	  | 	pkg/util/future/future_test_test/pkg/util/future/future_test.go:67
        	            	  | pkg/util/future/future_test_test.TestFuture
        	            	  | 	pkg/util/future/future_test_test/pkg/util/future/future_test.go:74
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1446
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1594
        	            	Wraps: (2) channel not ready
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestFuture
--- FAIL: TestFuture (0.00s)

Parameters: TAGS=bazel,gss,race

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

/cc @cockroachdb/unowned

This test on roachdash | Improve this report!

Jira issue: CRDB-26089

Epic CRDB-11732
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Mar 28, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Mar 28, 2023
@cockroach-teamcity
Copy link
Member Author

pkg/util/future/future_test.TestFuture failed with artifacts on release-23.1 @ 2f86475f2e3d713b4c8c976c34dba99acce7c4c7:

=== RUN   TestFuture
    future_test.go:74: 
        	Error Trace:	pkg/util/future/future_test_test/pkg/util/future/future_test.go:74
        	Error:      	Received unexpected error:
        	            	channel not ready
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | pkg/util/future/future_test_test.TestFuture.func4
        	            	  | 	pkg/util/future/future_test_test/pkg/util/future/future_test.go:67
        	            	  | pkg/util/future/future_test_test.TestFuture
        	            	  | 	pkg/util/future/future_test_test/pkg/util/future/future_test.go:74
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1446
        	            	  | runtime.goexit
        	            	  | 	GOROOT/src/runtime/asm_arm64.s:1172
        	            	Wraps: (2) channel not ready
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestFuture
--- FAIL: TestFuture (0.00s)
Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@cockroach-teamcity cockroach-teamcity mentioned this issue Apr 22, 2023
Closed
@cockroach-teamcity
Copy link
Member Author

pkg/util/future/future_test.TestFuture failed with artifacts on release-23.1 @ c00896aaf2a443cffbccae5c38452dfceff6e8cb:

=== RUN   TestFuture
    future_test.go:74: 
        	Error Trace:	pkg/util/future/future_test_test/pkg/util/future/future_test.go:74
        	Error:      	Received unexpected error:
        	            	channel not ready
        	            	(1) attached stack trace
        	            	  -- stack trace:
        	            	  | pkg/util/future/future_test_test.TestFuture.func4
        	            	  | 	pkg/util/future/future_test_test/pkg/util/future/future_test.go:67
        	            	  | pkg/util/future/future_test_test.TestFuture
        	            	  | 	pkg/util/future/future_test_test/pkg/util/future/future_test.go:74
        	            	  | testing.tRunner
        	            	  | 	GOROOT/src/testing/testing.go:1446
        	            	  | runtime.goexit
        	            	  | 	src/runtime/asm_amd64.s:1594
        	            	Wraps: (2) channel not ready
        	            	Error types: (1) *withstack.withStack (2) *errutil.leafError
        	Test:       	TestFuture
--- FAIL: TestFuture (0.00s)

Parameters: TAGS=bazel,gss,race

Help

See also: How To Investigate a Go Test Failure (internal)

Same failure on other branches

This test on roachdash | Improve this report!

@tbg tbg added the T-cdc label Jun 30, 2023
@blathers-crl
Copy link

blathers-crl bot commented Jun 30, 2023

cc @cockroachdb/cdc

@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label Jun 30, 2023
@miretskiy miretskiy self-assigned this Jul 5, 2023
@miretskiy miretskiy mentioned this issue Jul 5, 2023
Merged
craig bot pushed a commit that referenced this issue Jul 5, 2023
@knz
Merge #105282 #106187
439a5b1 
105282: deps: remove go-libedit r=rickystewart a=knz

The libedit-based editor was deprecated in 23.1. We can remove it in 23.2. This simplifies the build system.

Release note: None
Fixes #105283.
Epic: CRDB-28893


106187: future: Fix a small race in the test r=miretskiy a=miretskiy

Fix a test which was racy because awaitable future may be completed immediately, while the previously arranged `WhenDone` callbacks have not finished running yet.

Fixes #99019
Fixes #99804
Fixes #102080

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
Co-authored-by: Yevgeniy Miretskiy <[email protected]>
@craig craig bot closed this as completed in 6880e71 Jul 5, 2023
@blathers-crl blathers-crl bot mentioned this issue Jul 5, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Jul 5, 2023
future: Fix a small race in the test
57ebe49 
Fix a test which was racy because awaitable future
may be completed immediately, while the previously arranged
`WhenDone` callbacks have not finished running yet.

Fixes #99019
Fixes #99804
Fixes #102080

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@miretskiy miretskiy

Labels
A-cdc Change Data Capture branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-cdc
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

future: Fix a small race in the test miretskiy/cockroach
3 participants
@tbg @cockroach-teamcity @miretskiy