Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changefeedccl: change max behind nanos description #99409

Closed
amruss opened this issue Mar 23, 2023 · 1 comment · Fixed by #101790
Closed

changefeedccl: change max behind nanos description #99409

amruss opened this issue Mar 23, 2023 · 1 comment · Fixed by #101790
Assignees
@samiskin
Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc

Comments

@amruss
Copy link
Contributor

amruss commented Mar 23, 2023 •
edited by exalate-issue-sync bot
Loading

The max_behind_nanos description in the status_vars page is: Largest commit-to-emit duration of any running feed

We should change this to be "time since last checkpoint"

Jira issue: CRDB-26155

Epic CRDB-8669
@amruss amruss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-cdc Change Data Capture T-cdc labels Mar 23, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 23, 2023

cc @cockroachdb/cdc

jayshrivastava added a commit to jayshrivastava/cockroach that referenced this issue Apr 11, 2023
@jayshrivastava
changefeedccl: rework max behind nanos metric
aa38da7 
Previously, this node-level metric would measure the maximum time between
the present and the oldest checkpoint seen by a change aggregator. Since
this metric was updated by in-memory checkpoints, it was prone to odd
behavior. For example:
- When a node restarts and a changefeed immediately begins a catchup scan,
  there are no checkpoints for this changefeed available to calculate the value
  of this metric. It's possible that an "inifinite" catchup scan could trigger
  where the metric would never get updated (

 had the description "Largest commit-to-emit duration of any running feed",

Informs: cockroachdb#97931
Closes: cockroachdb#97043
Closes: cockroachdb#99409
<what was there before: Previously, ...>
<why it needed to change: This was inadequate because ...>
<what you did about it: To address this, this patch ...>
@samiskin samiskin mentioned this issue Apr 18, 2023
Merged
@craig craig bot closed this as completed in ae5a1cb Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samiskin samiskin

Labels
A-cdc Change Data Capture C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: update changefeed metrics page samiskin/cockroach
2 participants
@samiskin @amruss