Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c2c: write local c2c roachtest for CI #99230

Closed
msbutler opened this issue Mar 22, 2023 · 1 comment · Fixed by #99468
Closed

c2c: write local c2c roachtest for CI #99230

msbutler opened this issue Mar 22, 2023 · 1 comment · Fixed by #99468
Assignees
@msbutler
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Mar 22, 2023 •
edited by cockroach-jira-scripts
Loading

We often merge c2c features without double checking how it affects the c2c roachtest framework. To avoid this, let's write a local roachtest that runs through CI that exercises the c2c roachtest framework.

Jira issue: CRDB-25775
@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery labels Mar 22, 2023
@msbutler msbutler self-assigned this Mar 22, 2023
@blathers-crl
Copy link

blathers-crl bot commented Mar 22, 2023

cc @cockroachdb/disaster-recovery

msbutler added a commit to msbutler/cockroach that referenced this issue Mar 23, 2023
@msbutler
c2c: increase portability of roachtest driver
bae23ba 
This small patch puts all roachtest driver logic into a main function, allowing
other test harnesses to initiate C2C roachtests.

Informs cockroachdb#99230

Release note: None

c2c: add acceptance test

This patch adds a lightweight acceptance test that calls the main c2c roachtest
driver. This will add a c2c roachtest to Essential CI, preventing future
patches from inadvertently breaking the C2C roachtest driver.

Fixes cockroachdb#99230

Release note: None
msbutler added a commit to msbutler/cockroach that referenced this issue Mar 24, 2023
@msbutler
c2c: increase portability of roachtest driver
513a040 
This small patch puts all roachtest driver logic into a main function, allowing
other test harnesses to initiate C2C roachtests.

Informs cockroachdb#99230

Release note: None
msbutler added a commit to msbutler/cockroach that referenced this issue Mar 24, 2023
@msbutler
c2c: add acceptance test
39ce62b 
This patch adds a lightweight acceptance test that calls the main c2c roachtest
driver. This will add a c2c roachtest to Essential CI, preventing future
patches from inadvertently breaking the C2C roachtest driver.

Fixes cockroachdb#99230

Release note: None
@msbutler msbutler mentioned this issue Mar 24, 2023
Merged
msbutler added a commit to msbutler/cockroach that referenced this issue Mar 24, 2023
@msbutler
c2c: add acceptance test
1aaa9d7 
This patch adds a lightweight acceptance test that calls the main c2c roachtest
driver. This will add a c2c roachtest to Essential CI, preventing future
patches from inadvertently breaking the C2C roachtest driver.

Fixes cockroachdb#99230

Release note: None
craig bot pushed a commit that referenced this issue Mar 24, 2023
@fqazi @msbutler
Merge #99438 #99468
a9e90a6 
99438: sql/schemachanger: block legacy schema changer operations earlier r=fqazi a=fqazi

Previously, it was possible for ADD/DROP CONSTRAINT and other declarative schema changer operations to collide with DROP TABLE in the legacy schema changer, since our gate was not early enough. So, some work would be done before the schema change was blocked with a retry error.
This patch prevents DROP TABLE/VIEW/SEQUENCE from executing until a declarative schema change on such objects is completed earlier.

Fixes: #99379

Release note: None

99468: c2c: add acceptance test r=stevendanna,renatolabs a=msbutler

c2c: add acceptance test

This patch adds a lightweight acceptance test that calls the main c2c roachtest
driver. This will add a c2c roachtest to Essential CI, preventing future
patches from inadvertently breaking the C2C roachtest driver.

Fixes #99230

Release note: None

Co-authored-by: Faizan Qazi <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
@craig craig bot closed this as completed in a411fe2 Mar 24, 2023
blathers-crl bot pushed a commit that referenced this issue Mar 24, 2023
@msbutler
c2c: increase portability of roachtest driver
c33384d 
This small patch puts all roachtest driver logic into a main function, allowing
other test harnesses to initiate C2C roachtests.

Informs #99230

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Mar 24, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue Mar 24, 2023
@msbutler
c2c: add acceptance test
e207064 
This patch adds a lightweight acceptance test that calls the main c2c roachtest
driver. This will add a c2c roachtest to Essential CI, preventing future
patches from inadvertently breaking the C2C roachtest driver.

Fixes #99230

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msbutler msbutler

Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

c2c: add acceptance test msbutler/cockroach
1 participant
@msbutler