-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql/tests: TestRandomSyntaxFunctions failed #99182
Comments
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 52e55d2ef172b7cfec14e8a0a954f8864b2be779: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ f351747ed97862fc037717cadec23f18073fb6be: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 186218edb86b5974501b2976cfd0704d4d6d1beb: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 3551dc089ac3efcb3772df2109164dcb01e79d8f: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ aec78f33d45a8376a0ecec885688bae60dbfb85c: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 7e72aae900c3ff4b44f1643c2d7ba55fbb2cbe23: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 5d5abe704b0551556c35d51aa673d3162f493aa8: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 63b683eab3e0ebfff812bb54fdac936c101d9383: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 35b724947ac464e6af45ce5193e34035fcacb1ef: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ e847e4358c004d4a8977ae26749768ad1d417fba: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ b432e8c20339de5cfa7c811a9ee6f5dc98d15a1e: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ af5e6abf7efbb1361252839703e3ef8e067c9410: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ de239a7438f44d382c9aefceb65d9c39911dabd2: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 2f96695f75b07c872ec5f146acc1fa198135768f: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ a9eb6d220fc0957d4f6f8261d447991e9d03b4ad: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ c8a4703f9853a442ac676b44d074b43eb387f60c: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ cf84c1c11f2f9c1a4a979033fa0af3befb2ccbcf: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 84905b8396e7cd7ef999b264faaafe13110d631a: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 6cce6c746150307a9ecf3b529dfd633a6985c110: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 2f86475f2e3d713b4c8c976c34dba99acce7c4c7: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ ad6ce866ea3b5c5bb47ba9a0ac19b721a0c98add: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
@fqazi will check if the timeout logic in this test can be improved. We might add a statement_timeout, or else make the statement runner more intelligent. |
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 6ccfa2ca599092e742151ea7017695e99567d6f1: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
Resettable timeout isn't at play with these tests, and the latest failure is a low truncate. Let me see if I can spot anything here |
Ah adopting a resettable timeout for these tests would generally improve their reliability. I'll get a PR up shortly, the execution times for individual statements are reasonable and we can get away from special casing statements out. |
cc @cockroachdb/disaster-recovery |
Previously, TestRandomSyntaxFunctions could flake since some operations could take a long time. A resettable timeout makes things more dynamic, and allows timeouts to be extended while other connections make progress for a limited time, which can help with certain builtins that are schema changes (i.e. they will wait on other connections). Fixes: cockroachdb#99182 Release note: None
Previously this builtin would crash if a bad job ID was passed in. This patch, adds check to confirm that a job can be found preventing the crash. Fixes: cockroachdb#99182 Release note: None
Previously, crdb_internal.tenant_span_stats would crash if the number of arguments were incorrect. This patch, adds a check for the parameter count. Fixes: cockroachdb#99182 Release note: None
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ d62a2f3ab1dff86bd80cac037b215121537a2a9a: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 043024b889af86e0b8f23f09619d8d3c2c9acd13: Fatal error:
Stack:
Log preceding fatal error
Same failure on other branches
|
Previously, crdb_internal.tenant_span_stats would crash if the number of arguments were incorrect. This patch, adds a check for the parameter count. Fixes: cockroachdb#99182 Release note: None
107233: sql: TestRandomSyntaxFunctions fix flakes r=fqazi a=fqazi Previously, this test could flake due to the following: 1. The timeout is used for specific functions, so moving to a resettable timeout is beneficial, which allows these to be extended as long as connections make progress 2. Panics inside crdb_internal.tenant_span_stats due to nil pointer dereferences. Fixes: #99182 Fixes: #107237 107358: sql: handle mixed-case for pg_get_serial_sequence r=rafiss a=rafiss fixes #107234 Release note (bug fix): The pg_get_serial_sequence builtin function can now handle mixed-case names correctly. Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
Previously, TestRandomSyntaxFunctions could flake since some operations could take a long time. A resettable timeout makes things more dynamic, and allows timeouts to be extended while other connections make progress for a limited time, which can help with certain builtins that are schema changes (i.e. they will wait on other connections). Fixes: cockroachdb#99182 Release note: None
sql/tests.TestRandomSyntaxFunctions failed with artifacts on release-23.1 @ 80c4895c566a7eaa6f16c4098980509dd3795ad7:
Fatal error:
Stack:
Log preceding fatal error
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-25738
The text was updated successfully, but these errors were encountered: