Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade/upgrades: TestMigrationWithFailuresMultipleAltersOnSameColumn failed #98991

Closed
cockroach-teamcity opened this issue Mar 19, 2023 · 0 comments · Fixed by #100644
Closed
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 19, 2023

upgrade/upgrades.TestMigrationWithFailuresMultipleAltersOnSameColumn failed with artifacts on master @ 65698efb7bc7e63d23ea43e43d3a74627608e657:

=== RUN   TestMigrationWithFailuresMultipleAltersOnSameColumn
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/effffcb4dff575c191a0d0aec2225271/logTestMigrationWithFailuresMultipleAltersOnSameColumn2973064099
    test_log_scope.go:79: use -show-logs to present logs inline
=== CONT  TestMigrationWithFailuresMultipleAltersOnSameColumn
    schema_changes_external_test.go:519: -- test log scope end --
--- FAIL: TestMigrationWithFailuresMultipleAltersOnSameColumn (54.40s)
=== RUN   TestMigrationWithFailuresMultipleAltersOnSameColumn/skip_none
    test_log_scope.go:161: test logs captured to: /artifacts/tmp/_tmp/effffcb4dff575c191a0d0aec2225271/logTestMigrationWithFailuresMultipleAltersOnSameColumn_skip_none2846862273
    test_log_scope.go:79: use -show-logs to present logs inline
    schema_changes_external_test.go:397: trying migration, expecting to fail
    schema_changes_external_test.go:406: intercepting the schema job
    schema_changes_external_test.go:422: intercepted schema change job: 849296151169957889
    schema_changes_external_test.go:429: canceling the migration job
    schema_changes_external_test.go:434: waiting for the migration job to finish.
    schema_changes_external_test.go:463: retrying migration, expecting to succeed
    schema_changes_external_test.go:468: waiting for the migration job to observe a mutation
    schema_changes_external_test.go:472: resuming the schema change job
    schema_changes_external_test.go:482: waiting for the schema job to reach the cancel status
    schema_changes_external_test.go:497: waiting for the new migration job to complete.
    schema_changes_external_test.go:515: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/upgrade/upgrades_test/pkg/upgrade/upgrades/schema_changes_external_test.go:515
        	Error:      	"[{INFO %!s(int64=1679255055948272000) %!s(int64=21305) upgrade/upgrades/schema_changes.go %!s(int64=119) skipping add-user-id-column operation as the schema change already exists. n1,job=MIGRATION id=849296161467465729,upgrade=1000022.2-90 %!s(uint64=263) %!s(bool=false) DEV %!s(uint32=0) %!s(uint32=0) %!s(uint32=0) 1}]" should have 0 item(s), but has 1
        	Test:       	TestMigrationWithFailuresMultipleAltersOnSameColumn/skip_none
    panic.go:522: -- test log scope end --
test logs left over in: /artifacts/tmp/_tmp/effffcb4dff575c191a0d0aec2225271/logTestMigrationWithFailuresMultipleAltersOnSameColumn_skip_none2846862273
    --- FAIL: TestMigrationWithFailuresMultipleAltersOnSameColumn/skip_none (40.54s)
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/sql-schema

This test on roachdash | Improve this report!

Jira issue: CRDB-25642

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Mar 19, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Mar 19, 2023
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Mar 19, 2023
craig bot pushed a commit that referenced this issue Mar 21, 2023
99121: *: skip flaky tests r=adityamaru a=adityamaru

Informs: #98987
Informs: #98020
Informs: #98905
Informs: #98564
Informs: #98991

Release note: None
Epic: none

Co-authored-by: adityamaru <[email protected]>
@rafiss rafiss removed the GA-blocker label Mar 27, 2023
@rafiss rafiss self-assigned this Mar 27, 2023
ajwerner added a commit to ajwerner/cockroach that referenced this issue Apr 4, 2023
We need to properly inject the bootstrap version, and we need to
not step through too many version or enable any version gates.

Fixes cockroachdb#98564
Informs cockroachdb#98991

Release note: None
@craig craig bot closed this as completed in 85abcf8 Apr 4, 2023
blathers-crl bot pushed a commit that referenced this issue Apr 4, 2023
We need to properly inject the bootstrap version, and we need to
not step through too many version or enable any version gates.

Fixes #98564
Informs #98991

Release note: None
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
2 participants