Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roachtest: can't restore backup #98918

Closed
cockroach-teamcity opened this issue Mar 18, 2023 · 1 comment · Fixed by #98959
Closed

roachtest: can't restore backup #98918

cockroach-teamcity opened this issue Mar 18, 2023 · 1 comment · Fixed by #98959
Assignees
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Milestone

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 18, 2023

roachtest.sqlsmith/setup=tpcc/setting=ddl-nodrop failed with artifacts on master @ 6c99966f604f3521acdb925b9f689529ffd46df3:

test artifacts and logs in: /artifacts/sqlsmith/setup=tpcc/setting=ddl-nodrop/run_1
(sqlsmith.go:120).func3: pq: the backup is from a version older than our minimum restoreable version 22.2

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/sql-queries

This test on roachdash | Improve this report!

Jira issue: CRDB-25587

@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. labels Mar 18, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone Mar 18, 2023
@blathers-crl blathers-crl bot added the T-sql-queries SQL Queries Team label Mar 18, 2023
@cucaroach cucaroach changed the title roachtest: sqlsmith/setup=tpcc/setting=ddl-nodrop failed roachtest: can't restore backup Mar 18, 2023
craig bot pushed a commit that referenced this issue Mar 18, 2023
98947: Revert "backupccl: disallow restore of backups older than the minimum supported binary version r=erikgrinaker a=adityamaru

This reverts commit c39e5e4.

This change caused lots of unrelated roachtests to break, reverting while we investigate those.
Failures are tracked in #98918.

Release note: None

Epic: None

Co-authored-by: adityamaru <[email protected]>
@cucaroach
Copy link
Contributor

Fixed via #98947

adityamaru added a commit to adityamaru/cockroach that referenced this issue Mar 19, 2023
Some roachtests rely on fixtures generated before 22.2. To restore
such fixtures that are outside our compatibility window we must run
the restore with `unsafe_restore_incompatible_version`.

Fixes: cockroachdb#98918

Release note: None
craig bot pushed a commit that referenced this issue Mar 20, 2023
98805: kvserver: unskip merge queue during snapshot test r=nvanbenschoten a=AlexTalks

This change unskips `TestMergeQueueDoesNotInterruptReplicationChange`, which was skipped as potentially flaky in #94951. Despite repeated stress testing, this test no longer seems flaky, and correctly gets an error if attempting to enqueue a range in the merge queue during a replication change.

Fixes: #94951

Release note: None

98809: sql/logictest: clarify retry comment r=mgartner a=mgartner

Epic: None

Release note: None

98844: testutils: move tenant or server logic into test server r=stevendanna a=herkolategan

The logic to decide between returning a default test tenant, if one was started, or the server has been added to `testcluster` previously, but `testserver` can also benefit from exposing this logic for tests that do not require a whole cluster. Hence, this logic has been refactored to be available in both test cluster and test server.

Epic: CRDB-18499

98888: kvserver: remove duplicate logging in s-rebalancer r=andrewbaptist a=kvoli

Previously, the store rebalancer would log `load-based replica transfers successfully brought...` even when the store was not below the max threshold. The store rebalancer also logs when there are no available replica rebalancing actions remaining but the store still above the desired load threshold: `ran out of replicas worth transferring and load`. This log line was duplicated in both the post range rebalancing phase and in exiting the range rebalancing phase.

This commit stops duplication by removing the exit log line and ensures that the `load-based replica transfers successfully brought...` log line occurs only when actually successful.

Resolves: #98867

Release note: None

98959: Revert "Revert "backupccl: disallow restore of backups older than the minimum supported binary version"" r=dt a=adityamaru

This reverts commit c510676.

Some roachtests rely on fixtures generated before 22.2. To restore
such fixtures that are outside our compatibility window we must run
the restore with `unsafe_restore_incompatible_version`.

Fixes: #98918
Fixes: #98930
Release note: None
Epic: none

98997: multitenant: Increase timeout for kvtenantccl r=knz a=ajstorm

The new TestTenantUpgradeInterlock test takes a long time to run (up to a minute locally) and has started timing out in nightly runs. On the suspicion that it's timing out strictly because it's long running, increase the timeout to see if that resolves the failures.

Release note: None

99021: ui: fix jobs column name r=maryliag a=maryliag

The Last Execution Time called was previously labelled as Last Modified Time by mistake.
This commit fixes to use the correct name.

Epic: None

Release note (ui change): Update the Jobs table column name to the correct Last Execution Time.

Co-authored-by: Alex Sarkesian <[email protected]>
Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Herko Lategan <[email protected]>
Co-authored-by: Austen McClernon <[email protected]>
Co-authored-by: adityamaru <[email protected]>
Co-authored-by: Adam Storm <[email protected]>
Co-authored-by: maryliag <[email protected]>
@mgartner mgartner moved this to Done in SQL Queries Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-sql-queries SQL Queries Team
Projects
Archived in project
3 participants