Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage for concurrent test operations #98635

Closed
rimadeodhar opened this issue Mar 14, 2023 · 0 comments
Closed

Increase test coverage for concurrent test operations #98635

rimadeodhar opened this issue Mar 14, 2023 · 0 comments
Assignees
@fqazi
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rimadeodhar
Copy link
Collaborator

rimadeodhar commented Mar 14, 2023 •
edited by fqazi
Loading

We should try to increase test coverage of concurrent operations in the end-to-end framework for declarative schema changer.

Including, things like:

  • All newly added schema changes in 23.1 with concurrent DML
  • Introduce testing for rollbacks and data integrity during/after

Jira issue: CRDB-25379

Epic CRDB-25375
@rimadeodhar rimadeodhar added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Mar 14, 2023
@exalate-issue-sync exalate-issue-sync bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Mar 14, 2023
fqazi added a commit to fqazi/cockroach that referenced this issue Mar 16, 2023
@fqazi
sql/schemachanger: add additional DML injection for testing
486fc48 
Previously, we lacked DML injection testing with
UPDATES/DELETES and non-empty tables. We also lacked
DML injection for new functionality in this release.
To address this, this patch will start populating tables
in certain tasks and add new DML injection.

Additionally, the backup/restore tests will fully validate
job state on completion as a sanity check. Job failures are allowed
if backfilling schema changes with DML (during the setup).

Fixes: cockroachdb#98635
Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Mar 16, 2023
@fqazi
sql/schemachanger: add additional DML injection for testing
f466a10 
Previously, we lacked DML injection testing with
UPDATES/DELETES and non-empty tables. We also lacked
DML injection for new functionality in this release.
To address this, this patch will start populating tables
in certain tasks and add new DML injection.

Additionally, the backup/restore tests will fully validate
job state on completion as a sanity check. Job failures are allowed
if backfilling schema changes with DML (during the setup).

Fixes: cockroachdb#98635
Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Mar 20, 2023
@fqazi
sql/schemachanger: add additional DML injection for testing
94a3055 
Previously, we lacked DML injection testing with
UPDATES/DELETES and non-empty tables. We also lacked
DML injection for new functionality in this release.
To address this, this patch will start populating tables
in certain tasks and add new DML injection.

Additionally, the backup/restore tests will fully validate
job state on completion as a sanity check. Job failures are allowed
if backfilling schema changes with DML (during the setup).

Fixes: cockroachdb#98635
Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Mar 21, 2023
@fqazi
sql/schemachanger: add additional DML injection for testing
fca1f00 
Previously, we lacked DML injection testing with
UPDATES/DELETES and non-empty tables. We also lacked
DML injection for new functionality in this release.
To address this, this patch will start populating tables
in certain tasks and add new DML injection.

Additionally, the backup/restore tests will fully validate
job state on completion as a sanity check. Job failures are allowed
if backfilling schema changes with DML (during the setup).

Fixes: cockroachdb#98635
Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Mar 23, 2023
@fqazi
workload/schemachanger: basic declarative schema changer support
068356a 
Previously, the randomized testing only supported,
the non-declarative schema changer. This patch adds support
for basic single statement transactions for testing
the declarative schema changer

Note: This entablement is only focused on very
minimal stability testing. Not implemented errors
are always ignored for now.

Informs: cockroachdb#98635

Release note: None
fqazi added a commit to fqazi/cockroach that referenced this issue Mar 23, 2023
@fqazi
sql/schemachanger: add additional DML injection for testing
7e2ebeb 
Previously, we lacked DML injection testing with
UPDATES/DELETES and non-empty tables. We also lacked
DML injection for new functionality in this release.
To address this, this patch will start populating tables
in certain tasks and add new DML injection.

Additionally, the backup/restore tests will fully validate
job state on completion as a sanity check. Job failures are allowed
if backfilling schema changes with DML (during the setup).

Fixes: cockroachdb#98635
Release note: None
@craig craig bot closed this as completed in 7e935b1 Apr 6, 2023
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fqazi @rimadeodhar