Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workloads: add ability to scale stats for insights workload #97983

Closed
j82w opened this issue Mar 3, 2023 · 0 comments · Fixed by #97982
Closed

workloads: add ability to scale stats for insights workload #97983

j82w opened this issue Mar 3, 2023 · 0 comments · Fixed by #97982
Assignees
@j82w
Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@j82w
Copy link
Contributor

j82w commented Mar 3, 2023 •
edited by cockroach-jira-scripts
Loading

There currently isn't an easy way to generate a large number of statistics. An option should be added to the insights workload to generate a large number to help test and validate everything works at scale.

Jira issue: CRDB-25000
@j82w j82w added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-observability Related to observability of the SQL layer T-sql-observability labels Mar 3, 2023
@j82w j82w self-assigned this Mar 3, 2023
@j82w j82w mentioned this issue Mar 3, 2023
Merged
craig bot pushed a commit that referenced this issue Mar 10, 2023
Merge #97982
9b202ba 
97982: workload: add scaleStats flag r=j82w a=j82w

1. Add `scaleStats` option. 2 threads will do the normal insights queries that cause issues like contention. The remaining threads will do a basic
query and change the app name before each call. This will generate a large number of unique stat that will hit the limit in a few minutes.

2. Remove the database flag. Use the more optimal `crdb_internal.generate_test_objects`
instead. It can generate dbs faster if trying to
test scalability with dbs.

Example:
`./cockroach workload run insights 'postgresql://[email protected]:26257/insights?sslmode=disable'  --scaleStats`

Epic: none
Closes: #97983

Release note: None

Co-authored-by: j82w <[email protected]>
@craig craig bot closed this as completed in 28fcaad Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j82w j82w

Labels
A-sql-observability Related to observability of the SQL layer C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workload: add scaleStats flag
1 participant
@j82w