-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roachtest: c2c/kv0 failed #97903
Comments
roachtest.c2c/kv0 failed with artifacts on master @ 20e2adda3c76c7172dd986c871df0ae9a346918f:
Parameters: |
roachtest.c2c/kv0 failed with artifacts on master @ fcea283ebca17a6d923c5d4b0401697438b77dbd:
Parameters: |
roachtest.c2c/kv0 failed with artifacts on master @ fcea283ebca17a6d923c5d4b0401697438b77dbd:
Parameters: |
roachtest.c2c/kv0 failed with artifacts on master @ cf14ad694ee562676f53e36fa8495206c3aed61f:
Parameters: |
roachtest.c2c/kv0 failed with artifacts on master @ cf14ad694ee562676f53e36fa8495206c3aed61f:
Parameters: |
roachtest.c2c/kv0 failed with artifacts on master @ 14b43be03c1c246765be17aa15245493a42c401d:
Parameters: |
roachtest.c2c/kv0 failed with artifacts on master @ 14b43be03c1c246765be17aa15245493a42c401d:
Parameters: |
roachtest.c2c/kv0 failed with artifacts on master @ 43a25a09f92408accdeb3cfed1eb35e02d375877:
Parameters: |
roachtest.c2c/kv0 failed with artifacts on master @ 43a25a09f92408accdeb3cfed1eb35e02d375877:
Parameters: |
Will be fixed by #97916 |
97916: kv: opt into Elastic CPU limiting resume spans r=adityamaru,arulajmani a=stevendanna In #96691, we changed ExportRequest such that it returns resume spans that result from the elastic CPU limiter all the way to the caller. This has at least two problems: 1) In a mixed-version state, the caller might not yet know how to handle resume spans. This could result in incomplete responses erroneous being used as if they were full responses. 2) The DistSender inspects a request to determine whether it may stop early. If it shouldn't be able to stop early, then the request is split up, possibly sent in parallel, and all responses are combined. The code which combines responses asserts that neither side has a resume span. As a result, we've seen failures such as crdb_internal.fingerprint(): combining /Tenant/2/Table/106/1/-{8403574544142222370/0-37656332809536692} with /Tenant/{2/Table/106/1/436440321206557763/0-3} since the change was made. Here, we add a new request header field to allow callers to indicate whether they are prepared to accept resume spans. Further, we add that new field into the logic in DistSender which decides how to process requests. The downside here is that crdb_internal.fingerprint won't have its requests sent in parallel. Release note: None Fixes #97886, #97903 Epic: none Co-authored-by: Steven Danna <[email protected]>
roachtest.c2c/kv0 failed with artifacts on master @ 20e2adda3c76c7172dd986c871df0ae9a346918f:
Parameters:
ROACHTEST_cloud=aws
,ROACHTEST_cpu=8
,ROACHTEST_encrypted=false
,ROACHTEST_fs=ext4
,ROACHTEST_localSSD=false
,ROACHTEST_ssd=0
Help
See: roachtest README
See: How To Investigate (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-24952
Epic CRDB-21942
The text was updated successfully, but these errors were encountered: